Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-990111: Add easy logging improvements #849

Merged
merged 47 commits into from
Feb 5, 2024
Merged

SNOW-990111: Add easy logging improvements #849

merged 47 commits into from
Feb 5, 2024

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Modify easy logging based on list of security improvements

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2024 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (fa09941) 83.75% compared to head (dd824e6) 83.79%.
Report is 1 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Tools/UnixOperations.cs 8.33% 11 Missing ⚠️
Snowflake.Data/Core/Session/EasyLoggingStarter.cs 93.18% 0 Missing and 3 partials ⚠️
...lake.Data/Configuration/EasyLoggingConfigFinder.cs 97.43% 0 Missing and 1 partial ⚠️
...lake.Data/Configuration/EasyLoggingConfigParser.cs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
+ Coverage   83.75%   83.79%   +0.04%     
==========================================
  Files          89       92       +3     
  Lines        9344     9475     +131     
  Branches      861      879      +18     
==========================================
+ Hits         7826     7940     +114     
- Misses       1295     1309      +14     
- Partials      223      226       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review January 16, 2024 23:44
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner January 16, 2024 23:44
sfc-gh-knozderko
sfc-gh-knozderko requested changes Jan 19, 2024
View reviewed changes
Snowflake.Data/Configuration/EasyLoggingConfigFinder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Configuration/EasyLoggingConfigFinder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Configuration/EasyLoggingConfigFinder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Configuration/EasyLoggingConfigFinder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Configuration/EasyLoggingConfigParser.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Session/EasyLoggingStarterTest.cs Outdated Show resolved Hide resolved
Snowflake.Data/Logger/EasyLoggerUtil.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Session/EasyLoggingStarterTest.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Session/EasyLoggingStarterTest.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Session/EasyLoggingStarterTest.cs Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit bd5d8da into master Feb 5, 2024
21 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-990111-Easy-Logging-Improvement branch February 5, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-lf @sfc-gh-knozderko